RFR: 8265480: add basic JVMCI support for JEP 309: Dynamic Class-File Constants [v2]
dnsimon at openjdk.java.net
Wed Apr 21 20:50:00 UTC 2021
On Wed, 21 Apr 2021 20:16:58 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> fixed date in copyright headers
> src/hotspot/share/jvmci/jvmciCompilerToVM.cpp line 659:
>> 657: }
>> 659: JVMCIObject result = JVMCIENV->call_PrimitiveConstant_forTypeChar(type2char(bt2), raw_value, JVMCI_CHECK_NULL);
> Given the above switch is total this part is unreachable? Did you mean for it to occur after the `if (!is_reference_type(bt)) ` block?
No - it should not be there at all: https://github.com/openjdk/jdk/pull/3578/commits/b70c7b1a64d51fce23edde860f04749e8e49d34f
Thanks for spotting.
More information about the hotspot-compiler-dev