RFR: 8265480: add basic JVMCI support for JEP 309: Dynamic Class-File Constants [v4]
psandoz at openjdk.java.net
Thu Apr 22 15:34:23 UTC 2021
On Thu, 22 Apr 2021 14:31:45 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> - added comment explaining box conversion of primitives
>> - added test for loading a List from a condy
> test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/TestDynamicConstant.java line 28:
>> 26: * @requires vm.jvmci
>> 27: * @summary Test CONSTANT_Dynamic resolution by HotSpotConstantPool.
>> 28: * @modules java.base/jdk.internal.org.objectweb.asm
> Instead of ASM, I would have preferred to use `test.java.lang.invoke.lib.InstructionHelper` like `CondyBSMInvocation` [does](https://github.com/openjdk/jdk/blob/05a764f4ffb8030d6b768f2d362c388e5aabd92d/test/jdk/java/lang/invoke/condy/CondyBSMInvocation.java#L56). However, I could not figure out how to use a test library from the `test/jdk` suite in the `test/hotspot/jtreg` suite. Do you know if that's possible @PaulSandoz ?
It might be (depending of source locations). I would need to look in more detail. I can do that as a follow on investigation/fix if need be, rather than block this PR?
More information about the hotspot-compiler-dev