RFR: 8265484: Fix up TRAPS usage in GenerateOopMap::compute_map and callers [v3]

Dean Long dlong at openjdk.java.net
Fri Apr 23 00:48:28 UTC 2021

On Thu, 22 Apr 2021 12:17:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>   Replace assert(false) with fatal()
>>   After a number of people examined this code it was decided that the best approach was to re-instate
>>   the call to fatal() in product builds, that would have been present in the CATCH macro, until recent
>>   changes converted that to an assert(). The code here is not prepared to continue if compute_map fails
>>   so we have to abort. Such failures are extremely unlikely (metaspace or resource-area OOM, or malformed
>>   bytecode where verification has been disabled).
> Good cleanup!

> Thanks @coleenp and @iklam for the re-reviews. @dean-long are you also okay with the latest version? It addresses your earlier concern.
> Thanks,
> David

Yes, looks good!


PR: https://git.openjdk.java.net/jdk/pull/3580

More information about the hotspot-compiler-dev mailing list