Integrated: 8265484: Fix up TRAPS usage in GenerateOopMap::compute_map and callers
dholmes at openjdk.java.net
Fri Apr 23 01:17:26 UTC 2021
On Mon, 19 Apr 2021 21:38:29 GMT, David Holmes <dholmes at openjdk.org> wrote:
> If compute_map encounters malformed bytecode, or an OOM condition then it can raise a LinkageError to be thrown in regular JavaThreads, and this is reflected in the use of TRAPS in a couple of methods. But for non-JavaThreads, and compiler threads, the occurrence of such an error is treated as a fatal error and we abort the VM.
> In addition, most of the callers of compute_map actually use the CATCH macro, which just clears the exception and will abort a non-product VM.
> This use of TRAPS is a problem for the change to convert TRAPS to JavaThread, because these methods are called by non-JavaThreads. To address this we change compute_map to create, but not throw, the exception and return a bool indicating whether an error occurred, and the caller can then choose to throw the exception itself.
> Testing: tiers 1-3
This pull request has now been integrated.
Author: David Holmes <dholmes at openjdk.org>
Stats: 44 lines in 4 files changed: 16 ins; 11 del; 17 mod
8265484: Fix up TRAPS usage in GenerateOopMap::compute_map and callers
Reviewed-by: iklam, dlong, coleenp
More information about the hotspot-compiler-dev