RFR: 8265911: assert(comp != __null) failed: Compiler instance missing
thartmann at openjdk.java.net
Mon Apr 26 09:51:30 UTC 2021
On Sun, 25 Apr 2021 08:56:39 GMT, Frank King <github.com+16741972+whjpji at openjdk.org> wrote:
> As I debugged into the code, the `_c1_count` was set to `1`  with flags `-XX:+EnableJVMCI -XX:+UseJVMCICompiler -XX:JVMCIHostThreads=1`. However,  would never be executed, and thus `_compilers` was `NULL`.
> When C1 is disabled, `_c1_count` should always be `0`, so I added this `#ifdef` guard to avoid changing value of `_c1_count` under this circumstance.
>  https://github.com/openjdk/jdk/blob/f1f2afda5a0ab8f213e8a1b5324a251928c8d81a/src/hotspot/share/compiler/compileBroker.cpp#L656
>  https://github.com/openjdk/jdk/blob/f1f2afda5a0ab8f213e8a1b5324a251928c8d81a/src/hotspot/share/compiler/compileBroker.cpp#L664
Looks good. Is it worth adding a regression test?
Marked as reviewed by thartmann (Reviewer).
More information about the hotspot-compiler-dev