RFR: 8265711: C1: Intrinsify Class.getModifier method [v2]
thartmann at openjdk.java.net
Tue Apr 27 13:09:37 UTC 2021
On Tue, 27 Apr 2021 12:56:25 GMT, Yi Yang <yyang at openjdk.org> wrote:
>>> Because is_intrinsic_support is not aware of the fact that getModifiers is an intrinsic method. So canonicalizer is even not applied.
>> But your first version (https://github.com/openjdk/jdk/pull/3616/commits/7f0be4e8a2cb4f6a9ef650b1b31c16f46716a257) already had the change to `is_intrinsic_supported`? Shouldn't that version have triggered test failures because it does not handle primitive types?
>>> With the new IR test framework, these kinds of problem would never happen, we can do verification at IR level.
>> Unfortunately not. The IR test framework currently only supports C2.
>> But your first version (7f0be4e) already had the change to is_intrinsic_supported? Shouldn't that version have triggered test failures because it does not handle primitive types?
> The first version only changes Canonicalizer::do_Intrinsic :_
Okay, maybe the force-push screwed up some of the history here, you should try to avoid that (it also makes it much harder to review changes incrementally).
More information about the hotspot-compiler-dev