RFR: 8266184: a few compiler/debug tests don't check exit code

Igor Ignatyev iignatyev at openjdk.java.net
Wed Apr 28 15:48:53 UTC 2021

On Wed, 28 Apr 2021 05:06:19 GMT, Igor Ignatyev <iignatyev at openjdk.org> wrote:

> Hi all,
> could you please review this small fix for `compiler/debug` tests?
> from JBS:
>> `compiler/debug/TestGenerateStressSeed.java`, `TestStressCM.java`, and `TestStressIGVNAndCCP.java` don't check the exit code of spawned JVMs, as a result, they might miss misconfiguration and/or defects. in fact, `TestStressIGVNAndCCP.java` uses a wrong flag name (`TraceIterativeIGVN` instead of `TraceIterativeGVN`) and this was unnoticed b/c we didn't check the exit code.
> the patch adds calls to `OutputAnalyzer::shouldHaveExitValue` and fixes `TestStressIGVNAndCCP.java` to use the right flag.
> testing:
> - [x] `test/hotspot/jtreg/compiler/debug` on `linux-x64-debug`
> Thanks,
> -- Igor

thanks, Tobias.


PR: https://git.openjdk.java.net/jdk/pull/3748

More information about the hotspot-compiler-dev mailing list