RFR: 8266251: compiler.inlining.InlineAccessors shouldn't run a test in driver VM

Igor Ignatyev iignatyev at openjdk.java.net
Wed Apr 28 21:10:17 UTC 2021

Hi all,

could you please review the patch which removes redundant and "incorrect" testing from `InlineAccessors` test? as `InlineAccessors::doTest` is called by the JVM which runs `Launcher` class, we aren't actually losing any coverage.

from JBS:
> `compiler.inlining.InlineAccessors` test executes `doTest` method in its `InlineAccessors::main`, but InlineAccessors is run in driver mode (so it's not expected to do actual testing and strictly speaking can be executed in JVM other than JVM under test).

-- Igor


Commit messages:
 - 8266251

Changes: https://git.openjdk.java.net/jdk/pull/3774/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3774&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8266251
  Stats: 6 lines in 1 file changed: 0 ins; 4 del; 2 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3774.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3774/head:pull/3774

PR: https://git.openjdk.java.net/jdk/pull/3774

More information about the hotspot-compiler-dev mailing list