RFR: 8266074: Vtable-based CHA implementation
vlivanov at openjdk.java.net
Fri Apr 30 22:05:52 UTC 2021
On Fri, 30 Apr 2021 20:13:19 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:
>> The test assumes `UseVtableBasedCHA` is on and some of the assertions it makes fail with `-XX:-UseVtableBasedCHA`. So, it would require all the changes in the test logic have to be guarded by a check whether UseVtableBasedCHA is on or off.
>> Considering `UseVtableBasedCHA` is turned on by default in the PR, I don't see much value in complicating the test.
> So only new implementation is tested with these changes in test. Got it. May be use:
> `@requires vm.opt.final.UseVtableBasedCHA == true`
I'm fine with both approaches.
Explicitly setting the flag looked to me more robust and clearer communicating the intent. But if you prefer `@requires`, I'll use it.
More information about the hotspot-compiler-dev