<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body bgcolor="white" lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Nils,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">This failure will occur even when intrinsification for Max[FD]/Min[FD] which this patch supported is disabled.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Try passing another option –XX:DisableIntrinsic=_maxD and test will still assert with non-intrinsified jitt’ed code, test case is not correct since its doing
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">an assert over direct floating point comparison.
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Will update the patch.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Jatin <o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"></a><b><span style="color:windowtext">From:</span></b><span style="color:windowtext"> hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces@openjdk.java.net]
<b>On Behalf Of </b>Nils Eliasson<br>
<b>Sent:</b> Tuesday, January 29, 2019 4:14 PM<br>
<b>To:</b> hotspot-compiler-dev@openjdk.java.net<br>
<b>Subject:</b> Re: [PATCH] 8217561 : X86: Add floating-point Math.min/max intrinsics<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hi again,<span style="font-size:12.0pt"><o:p></o:p></span></p>
<p>I can get the test to fail in the -XX:-TieredCompilation case:<o:p></o:p></p>
<pre style="font-variant-ligatures: normal;font-variant-caps: normal;orphans: 2;text-align:start;widows: 2;-webkit-text-stroke-width: 0px;text-decoration-style: initial;text-decoration-color: initial;overflow-wrap: break-word;white-space:pre-wrap;word-spacing:0px">java.lang.AssertionError: Unexpected result of double min/maxa = 4.823909266625017E17, b = -3.3333333333333331E17, result = (-3.333334338197927E17, 4.823908261760423E17), expected = (-3.3333333333333331E17, 4.823909266625017E17)<o:p></o:p></pre>
<pre> at compiler.intrinsics.math.TestFpMinMaxIntrinsics.dTest(TestFpMinMaxIntrinsics.java:113)<o:p></o:p></pre>
<pre> at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)<o:p></o:p></pre>
<pre> at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)<o:p></o:p></pre>
<pre> at compiler.intrinsics.math.TestFpMinMaxIntrinsics.main(TestFpMinMaxIntrinsics.java:124)<o:p></o:p></pre>
<pre> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)<o:p></o:p></pre>
<pre> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)<o:p></o:p></pre>
<pre> at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)<o:p></o:p></pre>
<pre> at java.base/java.lang.reflect.Method.invoke(Method.java:567)<o:p></o:p></pre>
<pre> at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)<o:p></o:p></pre>
<pre> at java.base/java.lang.Thread.run(Thread.java:835)<o:p></o:p></pre>
<p>Allow compilation of the methods in the test:<o:p></o:p></p>
<p>"-XX:CompileCommand=compileonly,compiler.intrinsics.math.TestFpMinMaxIntrinsics*"<o:p></o:p></p>
<p>And add a loop in the main method, so the test case is run multiple times.<o:p></o:p></p>
<p>Regards,<o:p></o:p></p>
<p>Nils<o:p></o:p></p>
<p><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 2019-01-29 11:02, Nils Eliasson wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p>Hi Jatin,<o:p></o:p></p>
<p>The diffs in your webrev have the wrong permissions - they return "403 - Forbidden".<o:p></o:p></p>
<p>The patch is readable though, so I will have a look.<o:p></o:p></p>
<p>Regards,<o:p></o:p></p>
<p>Nils<o:p></o:p></p>
<div>
<p class="MsoNormal">On 2019-01-29 05:18, Bhateja, Jatin wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi All,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Please find attached a patch for intrinsification for java library methods Math.max and Math.min for scalar floating point types (float and double).<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">New intrinsics match the semantics of java library function and takes care of NaN and signed zero operands.
<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Webrev : <a href="http://cr.openjdk.java.net/~sviswanathan/8217561/webrev.01/">
http://cr.openjdk.java.net/~sviswanathan/8217561/webrev.01/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Kindly review.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Jatin <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
</blockquote>
</div>
</body>
</html>