Code review request: NMT: assertion failed: assert(rec->addr() + rec->size() <= cur->base()) failed: Can not overlap in memSnapshot.cpp

Zhengyu Gu at
Thu Nov 1 06:38:19 PDT 2012

Hi David,

Thanks for reviewing.

On 10/31/2012 9:32 PM, David Holmes wrote:
> On 1/11/2012 2:12 AM, Zhengyu Gu wrote:
>> NMT did not allow overlapped commit on memory regions, which is
>> incorrect. Committing overlapped memory regions should be allowed, as
>> long as the regions are within a reserved region.
> So the overlapping stacks that were detected is perfectly valid?
No, it is very disturbing one, now is tracked by 8001743. This one only 
deals with overlapping committed regions.

> The renaming from contains_xx to contain_xx is not correct. "contains" 
> is the correct form to use, and "overlaps" rather than "overlap".
> Why the variable rename in VMMemPointerIterator::add_reserved_region? 
> Given it is initialized from current() then 'cur' seems quite 
> acceptable. Otherwise maybe it is current() that has the wrong name? 
> The renaming generates a lot of noise in the webrev - it is hard to 
> see the actual substantive changes that were made.
They are the results of recent clean coding discussions. I agree they 
are noises, I will revert renaming changes.



> Cheers,
> David
>> Thanks,
>> -Zhengyu

More information about the hotspot-dev mailing list