Request for review 8003722: More gcc 4.7 compilation errors
david.holmes at oracle.com
Sun Nov 25 12:33:10 PST 2012
Okay I withdraw my objections otherwise this will never get fixed. gcc
itself says use "this->" so be it. Plus push when ready.
For the record I'm hitting these kind of problems with gcc 4.6 as well.
It's in build-infra repo so may be down-rev on previous hotspot changes.
On 22/11/2012 12:18 AM, Coleen Phillimore wrote:
> On 11/20/2012 9:52 PM, David Holmes wrote:
>> Sorry but I must protest. After the last fix we were returned to an
>> unpleasant mixture of using directives and this-> augmentation. The
>> fix that was lost had applied the using directive.
>> Can we please use the using directive and just fix these once and for
> Okay, someone will have to contribute the "using" fix then. I don't know
> what to use in "using"!
> Please do this very soon since the VM doesn't build on gcc 4.7 (again!)
>> Otherwise get rid of all using directives. But lets have a consistent
>> approach here.
>> On 21/11/2012 11:44 AM, Coleen Phillimore wrote:
>>> Summary: Add a few more this->qualifications.
>>> Reviewed-by: coleenp
>>> Contributed-by: duboscq at ssw.jku.at
>>> Ran runThese tests with CMS gc. I want to check this into hotspot-gc
>>> since it has the other changes (hotspot-rt doesn't yet).
More information about the hotspot-dev