[14] RFR(XS): 8230762: Change MacroAssembler::debug32/64 to use fatal instead of assert

Vladimir Ivanov vladimir.x.ivanov at oracle.com
Tue Sep 10 08:49:24 UTC 2019

x86 part looks good.

Best regards,
Vladimir Ivanov

On 09/09/2019 17:14, Christian Hagedorn wrote:
> Hi
> Please review the following patch:
> https://bugs.openjdk.java.net/browse/JDK-8230762
> http://cr.openjdk.java.net/~chagedorn/8230762/webrev.00/
> The webrev is based on JDK-8225653. MacroAssembler::debug32/64 is 
> changed such that the last operation is fatal(). I think that some 
> additional instructions like ThreadStateTransition::transition or 
> tty->print_cr are then not needed anymore. I also ensured that after 
> each debug32/64 call a hlt is directly emitted (which was required in 
> generate_verify_oop - in MacroAssembler::stop we already have a hlt 
> instruction afterwards).
> Thank you!
> Best regards,
> Christian

More information about the hotspot-dev mailing list