RFR(XS): 8230762: Change MacroAssembler::debug32/64 to use fatal instead of assert
christian.hagedorn at oracle.com
Wed Sep 11 05:19:13 UTC 2019
Thanks for your review!
On 10.09.19 10:49, Vladimir Ivanov wrote:
> x86 part looks good.
> Best regards,
> Vladimir Ivanov
> On 09/09/2019 17:14, Christian Hagedorn wrote:
>> Please review the following patch:
>> The webrev is based on JDK-8225653. MacroAssembler::debug32/64 is
>> changed such that the last operation is fatal(). I think that some
>> additional instructions like ThreadStateTransition::transition or
>> tty->print_cr are then not needed anymore. I also ensured that after
>> each debug32/64 call a hlt is directly emitted (which was required in
>> generate_verify_oop - in MacroAssembler::stop we already have a hlt
>> instruction afterwards).
>> Thank you!
>> Best regards,
More information about the hotspot-dev