RFR (L) JDK-8230505: Replace JVM type comparisons to T_OBJECT and T_ARRAY with call to is_reference_type
lois.foltan at oracle.com
Wed Sep 11 18:55:12 UTC 2019
On 9/11/2019 12:35 PM, coleen.phillimore at oracle.com wrote:
> Not sure if I agree with the changes to make is_reference_type()
> called in the default label of a case statement.
Thanks Coleen for the review. I too share your concern about calling
is_reference_type in the default label of the case statement, however I
plan to leave as-is because it does allow for future reference types
like potentially valhalla inline types.
> Wow, there were a lot of these. The rest of the change looks great.
> On 9/11/19 11:29 AM, Lois Foltan wrote:
>> Please review the following change to call is_reference_type() when
>> checking if a type is a T_OBJECT or a T_ARRAY.
>> open webrev at:
>> bug link: https://bugs.openjdk.java.net/browse/JDK-8230505
>> Builds: all tier1 builds, did build with Shenandoah GC, and Solaris
>> Testing: hs-tier1-4 & jdktier1-2 (all platforms), hs-tier5-8 (linux-x64)
More information about the hotspot-dev