RFR (L) JDK-8230505: Replace JVM type comparisons to T_OBJECT and T_ARRAY with call to is_reference_type

Lois Foltan lois.foltan at oracle.com
Thu Sep 12 15:40:40 UTC 2019

On 9/11/2019 4:38 PM, dean.long at oracle.com wrote:
> This makes me wish we could call BasicType::is_reference_type() :-)
> I was going to suggest replacing the small number of 
> "is_reference_type(result->get_type()))" with 
> "result->is_reference_type()", but maybe it's not worth adding a 
> helper method for so few uses.  It does look more "OO" however.

Thanks Dean for taking a look at the webrev.  I am leaving the change as 
is.  As you mention a helper method might not be worth adding in this case.


> dl
> On 9/11/19 8:29 AM, Lois Foltan wrote:
>> Please review the following change to call is_reference_type() when 
>> checking if a type is a T_OBJECT or a T_ARRAY.
>> open webrev at: 
>> http://cr.openjdk.java.net/~lfoltan/bug_jdk8230505.0/webrev/index.html
>> bug link: https://bugs.openjdk.java.net/browse/JDK-8230505
>> Builds: all tier1 builds, did build with Shenandoah GC, and Solaris 
>> builds
>> Testing: hs-tier1-4 & jdktier1-2 (all platforms), hs-tier5-8 (linux-x64)
>> Thanks,
>> Lois

More information about the hotspot-dev mailing list