RFR(XS): 8231058: VerifyOops crashes with assert(_offset >= 0) failed: offset for non comment?
david.holmes at oracle.com
Mon Sep 23 08:25:52 UTC 2019
On 17/09/2019 12:19 am, Tobias Hartmann wrote:
> please review the following patch:
> I've accidentally broke CodeStrings::find_last with my patch for JDK-8224624  but didn't notice
> because the failure only triggers with -XX:+VerifyOops and apparently we don't have any tests that
> execute with that flag.
> The problem is that CodeString::offset() should only be called for comments. I've modified the
> condition accordingly. I've verified that the behavior is now equivalent to before JDK-8224624.
Functional change looks good. Thanks for explaining the history to me. :)
In the test do we generally use -XX:+IgnoreUnrecognizedVMOptions with
develop flags or should we @require a debug vm?
>  https://bugs.openjdk.java.net/browse/JDK-8224624
More information about the hotspot-dev