equest for review (small): 6621728 "Heap inspection should not crash in the face of C-heap exhaustion"

Y Srinivas Ramakrishna Y.S.Ramakrishna at Sun.COM
Tue Dec 18 00:00:18 UTC 2007


[A set of patches as well as a gzipped tarball of the webrev is attached.
Should your mail servers strip either of the attachments, you may manually
access them from the archives of this mailing list. For those internal
to Sun, a webrev pointer of these changes can be found off of
the "Suggested Fix" section of the CR. Thanks a lot for your reviews!]
-----------------------------

Fixed 6621728: Heap inspection should not crash in the face of C-heap exhaustion

When requisite support data structures for accumulating the statistics
cannot be allocated because of C-heap exhaustion, we now either simply
refuse to compute the histogram information or report the extent of
undercounting (depending on which allocation(s) did not succeed).

[*] I also took the opportunity to clean up and consolidate some
statistics reporting associated with CMS's free list spaces that
came to light from a recent customer interaction.

The changes directly related to the original bug are the first two
files in the webrev (or in the patch file). The remaining files contain
changes related to the clean-up in [*] above.

Fix verified: yes

Verification Testing: artificially injected allocation
    failures; tested +PrintClassHistogram with SPECjvm98;
    dumped FLS census data and checked formatting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cms_bugs.patch
Type: text/x-patch
Size: 38849 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20071217/a87eeb98/cms_bugs.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: webrev.6621728.tar.gz
Type: application/x-gzip
Size: 2125391 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20071217/a87eeb98/webrev.6621728.tar.gz>


More information about the hotspot-gc-dev mailing list