request for review (medium): 6722113
Y Srinivas Ramakrishna
Y.S.Ramakrishna at Sun.COM
Thu Nov 20 02:03:15 UTC 2008
Will fix that. Thanks for your review, John!
(Thanks also to Andrey for his earlier review, sent separately!)
----- Original Message -----
From: John Coomes <John.Coomes at Sun.COM>
Date: Wednesday, November 19, 2008 5:58 pm
Subject: Re: request for review (medium): 6722113
To: Y Srinivas Ramakrishna <Y.S.Ramakrishna at Sun.COM>
Cc: hotspot-gc-dev at openjdk.java.net
> Y Srinivas Ramakrishna (Y.S.Ramakrishna at Sun.COM) wrote:
> > 6722113 CMS: Incorrect overflow handling during precleaning of
> Reference lists
> > http://bugs.sun.com/view_bug.do?bug_id=6722113
> > webrev: http://webrev.invokedynamic.info/ysr/6722113/
> > ...
> Looks good to me. One nit: instead of adding a friend decl to
> CMSKeepAliveClosure, I think it'd be better to add a public accessor
> for the _concurrent_precleaning boolean and have
> CMSDrainMarkingStackClosure use that.
More information about the hotspot-gc-dev