CRR (XS): 7123165: G1: output during parallel verification can get messed up

Bengt Rutisson bengt.rutisson at
Tue Dec 20 15:25:28 UTC 2011


Looks good to me. 

One style question. Line 97. Would you be ok with adding a newline after "template <class T>"?

I think that's common in hotspot and it's what is done on line 193.


20 dec 2011 kl. 14:38 skrev Tony Printezis <tony.printezis at>:

> Hi all,
> Can I have a couple of quick reviews for this very small change (< 10 lines changed)?
> During parallel verification each worker now takes a lock after it detects a failure and while it's generating output. This way the output from separate workers is not interleaved and it's easier to read. I came across this issue while testing some recent changes and this patch made my life easier. It might make your life easier some day too. :-)
> Tony

More information about the hotspot-gc-dev mailing list