request for review (M), 6458402: 3 jvmti tests fail with CMS and +ExplicitGCInvokesConcurrent

Alan Bateman Alan.Bateman at
Tue Jan 4 16:11:07 UTC 2011

Daniel D. Daugherty wrote:
> :
>> This fix adds the missing JVMTI GC callbacks for CMS:
>> Webrev:
> Very nicely done. You should ping Alan B. to see if he has
> time to sanity check the JVM/TI tap map stuff...
I've just scanned it (haven't had time to do detailed review yet) but it 
looks pretty good to me. The only thing I notice is one or two stale 
comments. For example the hashmap() function no longer has an oop as 
argument but is still commented as "return the appropriate hashmap for a 
given object". I also wonder about the rehashing and whether it might be 
cheaper to re-hash to same slot rather than accumulating the moved 
entries in the delayed_add list. Keith may have measured this already.


More information about the hotspot-gc-dev mailing list