Request for review (S): 7099454 /bin/sh does not support syntax used in the src/os/posix/launcher/launcher.script shell script
tom.rodriguez at oracle.com
Tue Oct 11 16:37:10 UTC 2011
Looks good. Thanks for fixing this.
On Oct 11, 2011, at 2:06 AM, Bengt Rutisson wrote:
> Hi all,
> Sending this review request to both Runtime and GC. I think the change is Runtime responsibility, but I would like to submit it to hotspot-gc since it is getting in the way of testing that I am doing at the moment.
> The problem is that the hotspot script that the build process creates has been updated to use /bin/sh instead of /bin/bash. This is more correct since bash is optional. But the /bin/sh shell on Solaris does not accept some of the syntax in the script.
> In particular the $() notation is not supported by Solaris /bin/sh. The script also contains the bash specific "source" command.
> The fix is to change this to use `` and . respectively.
> 7099454 /bin/sh does not support syntax used in the src/os/posix/launcher/launcher.script shell script
> Tested the new script on Linux (Ubuntu) and Solaris. Ran JPRT.
More information about the hotspot-gc-dev