CRR (XS): 7091032: G1: assert failure when NewRatio is used

Y. S. Ramakrishna y.s.ramakrishna at
Thu Sep 15 19:29:50 UTC 2011

Your changes look good.

As regards the text (which predates your changes) in the warning,
the verb should be "override" rather than "overrides".

-- ramki

On 09/15/11 08:59, Tony Printezis wrote:
> Hi all,
> I'd like to get a couple of code review for this very small change to 
> avoid an assert failure when NewRatio is explicitly set 
> (size_to_region_num() takes a size parameter in bytes, so passing a 
> region number is incorrect):
> I also changed a tty->print_cr statement into a warning to be consistent 
> with what we do in similar situations.
> Thanks,
> Tony

More information about the hotspot-gc-dev mailing list