RFR(S): 7095243: Disambiguate ReferenceProcessor::_discoveredSoftRefs
bengt.rutisson at oracle.com
Tue Sep 27 18:47:24 UTC 2011
Thanks for fixing this! Looks good.
Two questions regarding minor things:
* You call the new field "_discovered_refs" which I think is correct
according to the naming convetions. However, the old fields had a
different convetion - they are called _discoveredSoftRefs etc. To be
consistent would it be worth calling the new field _discoveredRefs or
rename the old fields to _discovered_soft_refs etc?
* I think the accessor methods that you added in referenceProcessor.hpp:
discovered_soft_refs(), discovered_weak_refs(), discovered_final_refs(),
discovered_phantom_refs() are not used anywhere. Do you want to keep
The above are just questions. I am fine with the change as it is.
On 2011-09-27 19:08, John Cuthbertson wrote:
> Hi Everyone,
> Can I have a couple of volunteers review the changes for this CR? The
> webrev can be found at:
> As part of the review comments for 6484982 (adding reference
> processing to G1 evacuation pauses) a couple of the reviewers thought
> that using _discoveredSoftRefs when referring to the entire array of
> discovered lists was unclear and it was requested that role of
> _discoveredSoftRefs be disambiguated. These changes address that
> review comment. I have renamed the array of discovered reference lists
> (_discoveredSoftRefs et al are just pointers into the array) and use
> the more generic name in the contexts where we are referring to the
> entire array.
> Testing: Dacapo2006 and GC locker test from the GC test suite with
> _all_ collectors and jprt.
More information about the hotspot-gc-dev