Request for review (S): 7167069: 6 VM flags crash the VM when queried via jinfo
bengt.rutisson at oracle.com
Thu May 10 20:33:27 UTC 2012
On 2012-05-10 22:00, John Coomes wrote:
> Bengt Rutisson (bengt.rutisson at oracle.com) wrote:
>> Thanks for looking at this.
>> On 2012-05-10 11:37, Stefan Karlsson wrote:
>>> The fix looks good, but the test needs a copyright header and should
>>> probably use two spaces for the indentations.
>> There seem to be some inconsistencies within JTReg with regards to both
>> copyright and indentation. But I did as you suggested. Here's an updated
> Looks good to me except for a nit on the copyright - the test is a new
> file, so list just the current year (remove 2008).
Good catch. Coleen pointed that out as well, so I fixed it before I
started the JPRT job. The push job is currently executing on
hotspotwest, so unfortunately I can't add you as a reviewer. But thanks
for looking at this!
>>> On 2012-05-10 11:07, Bengt Rutisson wrote:
>>>> Hi all,
>>>> Can I have some reviews of this simple fix:
>>>> Sending this to both Runtime and GC. The change is in runtime code,
>>>> but all the concerned flags are GC flags and I plan to push this
>>>> through the GC repository unless there are any objections to that.
>>>> When command line flags with the double type were introduced the
>>>> methods Flag::print_on() and Flag::print_as_flag() were not updated
>>>> correspondingly. The Flag::print_on() method was updated as part of
>>>> this change:
>>>> But the Flag::print_as_flag() still didn't handle doubles.
>>>> I created a JTReg test that should test one flag of each supported type.
More information about the hotspot-gc-dev