RFR (XXS): 7158682: G1: Handle leak when running nsk.sysdict tests

Bengt Rutisson bengt.rutisson at oracle.com
Tue May 15 06:14:56 UTC 2012


Looks good! Thanks for doing this change. It should solve the memory 
leak for CMS as well.


On 2012-05-14 21:22, John Cuthbertson wrote:
> Hi Everyone,
> I have a new webrev based upon a suggestion from Bengt and Mikael 
> Gerdin which can be found here: 
> http://cr.openjdk.java.net/~johnc/7158682/webrev.1/
> Testing:
> * GC test suite with G1 and CM (both with and without biased locking 
> enabled).
> JohnC
> On 04/25/12 11:08, John Cuthbertson wrote:
>> Hi Everyone,
>> Can I have a couple of volunteers to review this fairly small change? 
>> The webrev can be found at: 
>> http://cr.openjdk.java.net/~johnc/7158682/webrev/
>> Summary:
>> This issue was mainly caused by the excessively high number of GC 
>> retry attempts seen (and fixed) in 7147724. Each time we retry the GC 
>> we allocate a handle to hold the pending list lock and there is no 
>> HandleMark around the code that retries the GC. As a result of the 
>> combination of these two factors, we ran out of C heap and couldn't 
>> allocate a new HandleArea. The fixes for 7147724 address the 
>> excessive retry attempts - but we can still retry the GC if the 
>> prologue operations are not successful and we still don't free the 
>> handles allocated in the prologues of the attempted GC operations. 
>> The changes for this CR address this last issue.
>> Many thanks to Mikael Gerdin for his initial diagnosis of the issue.
>> Testing:
>> The failing test cases (with the changes for 7147724 removed and 
>> instrumentation in the HandleMark class); GC test suite with 
>> +ExplicitGCInvokesConcurrent; jprt
>> Thanks,
>> JohnC

More information about the hotspot-gc-dev mailing list