Request for review (vs) - 7199923

Srinivas Ramakrishna ysr1729 at gmail.com
Thu Sep 20 21:39:14 UTC 2012


Looks good. Was it mainly for the system class loader that this turned out
to be a problem because of the
very large number of classes it loads, although of course the linear walk
can result in quadratic lookup
complexity which makes it bad in general. (The other thing would be to have
the set be a tree (or a skip list),
splitting by some key such as full class name. Anyway, OK to throw away the
frequent assertion checking for now.)

-- ramki

On Thu, Sep 20, 2012 at 11:36 AM, Jon Masamitsu <jon.masamitsu at oracle.com>wrote:

> 7199923: NPG: tools/javac/T7093325.java timeout
>
> The method has_defined() checks that a class is in
> the classloader's list of classes. has_defined() was
> used in an assertion when doing marking and
> adjusting of pointers in a class. Doing that check
> for every class spends too much time looking
> down the list of a classloader's classes.
>
> http://cr.openjdk.java.net/~**jmasa/7199923/webrev.00/<http://cr.openjdk.java.net/%7Ejmasa/7199923/webrev.00/>
>
> I'd like to get this back for testing tonight so my
> apologies if I cut short the review period.  Please
> send your comments in any event and I'll fix
> any problems in a second CR.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20120920/3a0e0411/attachment.htm>


More information about the hotspot-gc-dev mailing list