RFR (S): 8004172: Update jstat counter names to reflect metaspace changes

Mandy Chung mandy.chung at oracle.com
Tue Feb 5 20:30:58 UTC 2013


Also, the jstat man page needs to be updated per this change (I mentioned
this in the previous review [1])

http://download.java.net/jdk8/docs/technotes/tools/share/jstat.html

You can contact the docs team for this.
Mandy
[1] 
http://mail.openjdk.java.net/pipermail/serviceability-dev/2013-January/007957.html

On 2/5/13 12:14 PM, Mandy Chung wrote:
> Hi Erik,
>
> On 2/4/13 8:01 AM, Erik Helin wrote:
>> There have been some updates to the hotspot code based on feedback from
>> the hotspot-gc-dev mailing list. The only change to the JDK code is that
>> the namespace is back to "sun.gc" :)
>>
>> New webrevs:
>> - jdk:http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.03/  <http://cr.openjdk.java.net/%7Eehelin/8004172/jdk/webrev.03/>
>> - hotspot:http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.03/  <http://cr.openjdk.java.net/%7Eehelin/8004172/hotspot/webrev.03/>
>>
> Looks good.  Minor nits:
>
> gcCapacityOutput1.awk - should the last column in L7 be removed?
> jstatGcMetaCapacityOutput1.sh - it's a new test and the copyright year should be 2013.
>
>
>> Note that the fixed tests will continue to fail until the HotSpot
>> part of the change finds it way into the tl forest.
>
> How are you going to integrate the hotspot and jdk fixes in a
> synchronized fashion?  We shall make sure the TL sun/tools/jstat
> tests pass at all times.
>
> Mandy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130205/80ffa082/attachment.htm>


More information about the hotspot-gc-dev mailing list