RFR (S): JDK-8006432 - Ratio flags should be unsigned
tao.mao at oracle.com
Tue Feb 5 23:41:02 UTC 2013
Looks good to me. I've manually checked all occurrences of the four
flags. They are treated properly after the change.
I'm not an official reviewer. But, as I understand, code reviewer needs
at least one official reviewer. So, push it!
On 1/25/2013 8:24 AM, Jesper Wilhelmsson wrote:
> Hi John,
> Thanks for the review!
> I have removed G1InitYoungSurvRatio and updated the webrev and the bug
> to reflect this.
> On 2013-01-25 01:27, John Cuthbertson wrote:
>> Hi Jesper,
>> Looks good to me.
>> Can you also remove the unused G1InitYoungSurvRatio from g1_globals.hpp?
>> On 1/24/2013 1:45 PM, Jesper Wilhelmsson wrote:
>>> I'm looking for a couple of reviews for this small change.
>>> Bug: JDK-8006432 - Ratio flags should be unsigned
>>> Four flags whose contents are assumed to be unsigned were stored in
>>> variables. I have changed these to be unsigned instead.
>>> Manual testing and JPRT.
More information about the hotspot-gc-dev