Request for review (S): 8008382: Remove redundant use of Atomic::add(jlong, jlong *) in create_new_gc_id()
bengt.rutisson at oracle.com
Mon Feb 18 13:21:18 UTC 2013
Could I have a couple of reviews for this change?
There is no need to use atomics in create_new_gc_id() since it is not
called by multiple threads in parallel. Also, Atomic::add(jlong, jlong
*) is broken for ARM.
We should remove the use of Atomic::add in create_new_gc_id() for now.
If we need this to be called by multiple threads in the future we have
to reconsider how this should be done. Either adding a lock or doing
some kind of 32 bit atomic work.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev