Request for review (S): 8008382: Remove redundant use of Atomic::add(jlong, jlong *) in create_new_gc_id()

Stefan Karlsson stefan.karlsson at oracle.com
Mon Feb 18 13:49:04 UTC 2013


Looks good.

You should probably remove the atomic.hpp include.

StefanK

On 02/18/2013 02:21 PM, Bengt Rutisson wrote:
>
> Hi all,
>
> Could I have a couple of reviews for this change?
> http://cr.openjdk.java.net/~brutisso/8008382/webrev.00/
>
> There is no need to use atomics in create_new_gc_id() since it is not 
> called by multiple threads in parallel. Also, Atomic::add(jlong, jlong 
> *) is broken for ARM.
>
> We should remove the use of Atomic::add in create_new_gc_id() for now. 
> If we need this to be called by multiple threads in the future we have 
> to reconsider how this should be done. Either adding a lock or doing 
> some kind of 32 bit atomic work.
>
> Thanks,
> Bengt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130218/1fd53c51/attachment.htm>


More information about the hotspot-gc-dev mailing list