request for review (s) - 8005672: Clean up some changes to GC logging with GCCause's

Srinivas Ramakrishna ysr1729 at gmail.com
Sat Jan 5 00:07:07 UTC 2013


Great, thanks! Changes look good to me.

reviewed.
-- ramki

On Fri, Jan 4, 2013 at 3:51 PM, Jon Masamitsu <jon.masamitsu at oracle.com>wrote:

>
>
> On 1/4/2013 3:02 PM, Srinivas Ramakrishna wrote:
>
>> Hi Jon, could you post examples of pre-unintended-change,
>> post-unintended-change and post-this-fix? (couldn't find it in the visible
>> part of the bug report)
>>
> Before unintended change (jdk7)
>
> [GC [ParNew: 69952K->8704K(78656K), 1.1970131 secs]
> 69952K->69906K(253440K), 1.1971601 secs] [Times: user=5.08 sys=0.78,
> real=1.20 secs]
>
> After unintended change - missing blank after "GC" (recent jdk8 promoted)
>
> [GC[ParNew: 69952K->8704K(78656K), 1.1672417 secs]
> 69952K->68461K(253440K), 1.1673949 secs] [Times: user=5.01 sys=0.75,
> real=1.17 secs]
>
> Fixed
>
> [GC [ParNew: 69952K->8704K(78656K), 1.1765617 secs]
> 69952K->68482K(253440K), 1.1767129 secs] [Times: user=5.06 sys=0.77,
> real=1.18 secs]
>
> Jon
>
>  Happy New Year!
>> -- ramki
>>
>> On Fri, Jan 4, 2013 at 2:03 PM, Jon Masamitsu<jon.masamitsu@**oracle.com<jon.masamitsu at oracle.com>
>> >wrote:
>>
>>  This is a clean up of some unintended white space changes in
>>> the GC logging output.
>>>
>>> http://cr.openjdk.java.net/~****jmasa/8005672/webrev.00/<http://cr.openjdk.java.net/%7E**jmasa/8005672/webrev.00/>
>>> <http:**//cr.openjdk.java.net/%**7Ejmasa/8005672/webrev.00/<http://cr.openjdk.java.net/%7Ejmasa/8005672/webrev.00/>
>>> >
>>>
>>> Thanks.
>>>
>>> Jon
>>>
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130104/d15ada8f/attachment.htm>


More information about the hotspot-gc-dev mailing list