request for review (s) - 8005452: Create new flags for Metaspace resizing policy

Vitaly Davidovich vitalyd at gmail.com
Tue Jan 15 13:55:56 UTC 2013


Hi Jon,

Does it make sense to validate that the new flags are consistent (I.e. max
>= min)? That is, if user changes one or both such that max < min, should
VM report an error and not start?

Thanks

Sent from my phone
On Jan 14, 2013 10:31 AM, "Jon Masamitsu" <jon.masamitsu at oracle.com> wrote:

> 8005452: Create new flags for Metaspace resizing policy
>
> Previously the calculation of the metadata capacity at which
> to do a GC (high water mark, HWM) to recover
> unloaded classes used the MinHeapFreeRatio
> and MaxHeapFreeRatio to decide on the next HWM.  That
> generally left an excessive amount of unused capacity for
> metadata.  This change adds specific flags for metadata
> capacity with defaults more conservative in terms of
> unused capacity.
>
> Added an additional check for doing a GC before expanding
> the metadata capacity.  Required adding a new parameter to
> get_new_chunk().
>
> Added some additional diagnostic prints.
>
> http://cr.openjdk.java.net/~**jmasa/8005452/webrev.00/<http://cr.openjdk.java.net/~jmasa/8005452/webrev.00/>
>
> Thanks.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130115/6b02b8c6/attachment.htm>


More information about the hotspot-gc-dev mailing list