request for review (s) - 8005452: Create new flags for Metaspace resizing policy
coleen.phillimore at oracle.com
Wed Jan 23 17:01:03 UTC 2013
It looks okay except I think passing SpaceManager* to get_new_chunk() is
really gross just to do a print out. I'd rather see the printing at
line 1014 moved to 2170 whether you get a new virtual space or not.
There's already a ton of output from TraceMetadataChunkAllocation &&
Verbose, but you can leave the printing at 1013 so you know which one
created a new virtual space.
On 01/14/2013 10:30 AM, Jon Masamitsu wrote:
> 8005452: Create new flags for Metaspace resizing policy
> Previously the calculation of the metadata capacity at which
> to do a GC (high water mark, HWM) to recover
> unloaded classes used the MinHeapFreeRatio
> and MaxHeapFreeRatio to decide on the next HWM. That
> generally left an excessive amount of unused capacity for
> metadata. This change adds specific flags for metadata
> capacity with defaults more conservative in terms of
> unused capacity.
> Added an additional check for doing a GC before expanding
> the metadata capacity. Required adding a new parameter to
> Added some additional diagnostic prints.
More information about the hotspot-gc-dev