RFR (S): 8004172: Update jstat counter names to reflect metaspace changes

Jon Masamitsu jon.masamitsu at oracle.com
Thu Jan 24 18:57:24 UTC 2013


I looked at the hotspot changes and they look correct.  But I'm
not sure that "sun.gc" should be in the name of the counter.  Maybe
use SUN_RT instead of SUN_GC.


On 1/24/2013 2:51 AM, Erik Helin wrote:
> Hi all,
> here are the HotSpot changes for fixing JDK-8004172. This change uses 
> the new namespace "sun.gc.metaspace" for the metaspace counters and 
> also removes some code from metaspaceCounters.hpp/cpp that is not 
> needed any longer.
> Note that the tests will continue to fail until the JDK part of the 
> change finds it way into the hotspot-gc forest.
> The JDK part of the change is also out for review on 
> serviceability-dev at openjdk.java.net.
> Webrev:
> HotSpot: http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.00/
> JDK: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.00/
> Bug:
> http://bugs.sun.com/view_bug.do?bug_id=8004172
> Testing:
> Run the jstat jtreg tests locally on my machine on a repository where 
> I've applied both the JDK changes and the HotSpot changes.
> Thanks,
> Erik

More information about the hotspot-gc-dev mailing list