RFR (S): JDK-8006432 - Ratio flags should be unsigned

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Fri Jan 25 16:24:49 UTC 2013


Hi John,

Thanks for the review!
I have removed G1InitYoungSurvRatio and updated the webrev and the bug to 
reflect this.
/Jesper


On 2013-01-25 01:27, John Cuthbertson wrote:
> Hi Jesper,
>
> Looks good to me.
>
> Can you also remove the unused G1InitYoungSurvRatio from g1_globals.hpp?
>
> Thanks,
>
> JohnC
>
> On 1/24/2013 1:45 PM, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> I'm looking for a couple of reviews for this small change.
>>
>> Bug: JDK-8006432 - Ratio flags should be unsigned
>>
>> Webrev:
>> http://cr.openjdk.java.net/~jwilhelm/8006432/webrev/
>>
>> Summary:
>> Four flags whose contents are assumed to be unsigned were stored in signed
>> variables. I have changed these to be unsigned instead.
>>
>> Testing:
>> Manual testing and JPRT.
>>
>> /Jesper
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jesper_wilhelmsson.vcf
Type: text/x-vcard
Size: 236 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130125/6bac9c91/jesper_wilhelmsson.vcf>


More information about the hotspot-gc-dev mailing list