RFR(S): 8007036: G1: Too many old regions added to last mixed GC

John Cuthbertson john.cuthbertson at oracle.com
Tue Jan 29 18:28:17 UTC 2013

Hi Vitaly,

Thanks for looking at the code changes. Response inline...

On 1/28/2013 2:36 PM, Vitaly Davidovich wrote:
> Hi John,
> In G1CollectorPolicy::calc_min_old_cset_length(), is it possible to 
> get 0 for G1MixedGCCountTarget? If so, will get div by zero there.

Good catch. There's nothing to stop a user specifying 
-XX:G1MixedGCCountTarget=0 even though it doesn't make sense. I've added:

   const size_t gc_num = MAX2((size_t) G1MixedGCCountTarget, 1);

in calc_min_old_cset_length().



More information about the hotspot-gc-dev mailing list