RFR (S): 8004172: Update jstat counter names to reflect metaspace changes
jon.masamitsu at oracle.com
Wed Jan 30 15:29:17 UTC 2013
Sorry to make extra work for you but I've been convinced
that SUN_GC is the right name to use. Even though the
metadata may seem (in my head) more like a runtime quantity,
it (class metadata) has been associated with GC historically
so should continue to be associated with GC. So the
SUN_GC is appropriate. Again, my apologies for flip-flopping
On 1/28/2013 7:14 AM, Erik Helin wrote:
> thanks for your review!
> On 01/24/2013 07:57 PM, Jon Masamitsu wrote:
>> I looked at the hotspot changes and they look correct. But I'm
>> not sure that "sun.gc" should be in the name of the counter. Maybe
>> use SUN_RT instead of SUN_GC.
> I've updated the code to use the SUN_RT namespace instead of the
> SUN_GC namespace. This also required changes to the JDK code.
> I've also added better error handling if a Java Out Of Memory
> exceptions occur is raised in PerfDataManager::create_variable.
> Finally, I've moved some common code to the function create_ms_variable.
> - hotspot: http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.01/
> - jdk: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.01/
> What do you think?
>> On 1/24/2013 2:51 AM, Erik Helin wrote:
>>> Hi all,
>>> here are the HotSpot changes for fixing JDK-8004172. This change uses
>>> the new namespace "sun.gc.metaspace" for the metaspace counters and
>>> also removes some code from metaspaceCounters.hpp/cpp that is not
>>> needed any longer.
>>> Note that the tests will continue to fail until the JDK part of the
>>> change finds it way into the hotspot-gc forest.
>>> The JDK part of the change is also out for review on
>>> serviceability-dev at openjdk.java.net.
>>> HotSpot: http://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.00/
>>> JDK: http://cr.openjdk.java.net/~ehelin/8004172/jdk/webrev.00/
>>> Run the jstat jtreg tests locally on my machine on a repository where
>>> I've applied both the JDK changes and the HotSpot changes.
More information about the hotspot-gc-dev