RFR (XS): 8021967: Deprecate -XX:DefaultMaxRAMFraction

Tao Mao tao.mao at oracle.com
Wed Jul 31 18:42:06 UTC 2013


Hi Bengt,

Is using !FLAG_IS_DEFAULT(DefaultMaxRAMFraction) to trigger the warning 
a little inaccurate compared to FLAG_IS_CMDLINE() in this case, given 
that we have the possibility of FLAG_IS_ERGO()?

Otherwise, it looks good.

Thanks.
Tao

On 7/31/13 11:28 AM, Bengt Rutisson wrote:
>
> Hi Vladimir,
>
> Thanks for looking at this!
>
> On 7/31/13 6:06 PM, Vladimir Kozlov wrote:
>> Bengt,
>>
>> You have special method in arguments.cpp check_deprecated_gc_flags(). 
>> Why not use it?
>
> I'm fine with that. I wasn't really sure whether to consider 
> DefaultMaxRAMFraction a GC flag or not. Anyway, either way is fine 
> with me. Here is a webrev with the warning message in 
> check_deprecated_gc_flags() instead:
>
> http://cr.openjdk.java.net/~brutisso/8021967/webrev.01/
>
> Jon and Thomas, what do you prefer?
>
> Thanks,
> Bengt
>
>>
>> Thanks,
>> Vladimir
>>
>> On 7/31/13 6:34 AM, Bengt Rutisson wrote:
>>>
>>> Hi all,
>>>
>>> Could I have a couple of reviews for this small fix?
>>>
>>> http://cr.openjdk.java.net/~brutisso/8021967/webrev.00/
>>>
>>> For JDK8 we need to print a warning message when 
>>> DefaultMaxRAMFraction is used on the command line. This is to allow us
>>> to remove it for JDK9. The flag was superseded by MaxRAMFraction in 
>>> 2009 for the JDK6u18 release.
>>>
>>> Thanks,
>>> Bengt
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130731/8833f200/attachment.htm>


More information about the hotspot-gc-dev mailing list