Request for review (s) - 8015851 :UseAdaptiveGCBoundary is broken
thomas.schatzl at oracle.com
Fri Jun 7 08:52:08 UTC 2013
On Wed, 2013-06-05 at 17:25 -0700, Jon Masamitsu wrote:
> Fixed the CR # in the subject.
> On 6/5/2013 1:27 PM, Jon Masamitsu wrote:
> > A recent changeset effectively removed the initialization of
> > performance counters used by the option UseAdaptiveGCBoundary
> > This changeset is built on top of the one for 8014546 and the
> > webrev comes in two parts.
> > The fix plus the test
> > http://cr.openjdk.java.net/~jmasa/8015851/webrev.00/
About the test: is there a way to actually test performance counter
initialization? So far it only checks whether the VM crashes, and not
whether initialization is okay.
> > Some cleanups of the code
> > http://cr.openjdk.java.net/~jmasa/8015851/webrev_refactor.00/
Just to make sure what this cleanup is about: move the call to
initialize_work() into the constructors of the generations, and clean up
some unused constructors.
If so, looks okay.
More information about the hotspot-gc-dev