Request for review (s) - 8015851 :UseAdaptiveGCBoundary is broken
bengt.rutisson at oracle.com
Fri Jun 7 09:21:20 UTC 2013
On 6/6/13 2:25 AM, Jon Masamitsu wrote:
> Fixed the CR # in the subject.
> On 6/5/2013 1:27 PM, Jon Masamitsu wrote:
>> A recent changeset effectively removed the initialization of
>> performance counters used by the option UseAdaptiveGCBoundary
Which change broke the initialization of the performance counters?
The code you add in ASPSOldGen::initialize_work() is very similar to the
code in PSOldGen::initialize(). The PSOldGen::initialize() method is
called from one (why not both?!?!) of the constructors for PSOldGen,
which means that it is called from one of the ASPSOldGen constructors.
But these constructors seem to be unused. Would it be possible to move
your code from ASPSOldGen::initialize_work() in to the constructor of
PSOldGen that is actually used?
>> This changeset is built on top of the one for 8014546 and the
>> webrev comes in two parts.
>> The fix plus the test
>> Some cleanups of the code
More information about the hotspot-gc-dev