RFR(M/L): 7145569: G1: optimize nmethods scanning
john.cuthbertson at oracle.com
Tue Jun 18 19:43:35 UTC 2013
Now worries. I changed the name of the routine. Initially I had a pop
routine but I didn't use it and deleted it.
On 6/14/2013 4:05 AM, Thomas Schatzl wrote:
> some minor comment:
> On Fri, 2013-06-14 at 12:15 +0200, Thomas Schatzl wrote:
>> Hi John,
>> I had some initial look at the code, first comments (mostly about
>> typos, comments) below:
>> On Thu, 2013-06-13 at 15:30 -0700, John Cuthbertson wrote:
>> - push_strong_code_root vs. add_strong_code_root
> Forgot to improve the comment, happens when I do not immediately write
> down the full comment...
> This is about the names of for pairing insertion/deletion operations for
> the data type. Imo push does not go well with remove, I would prefer the
> common use of add/remove instead of push/remove.
> While "push" also adds to the collection, push is commonly used for
> stack operation, and imo implies some stack like behavior. I cannot find
> any reason for that in case of remembered sets or an nmethod collection.
> All imo, and minor.
More information about the hotspot-gc-dev