CMS parallel initial mark; vm thread sneaking in Thread::try_lock()

Hiroshi Yamauchi yamauchi at google.com
Thu Jun 27 21:58:09 UTC 2013


I will fix this. Thanks.

On Thu, Jun 27, 2013 at 2:15 AM, Thomas Schatzl
<thomas.schatzl at oracle.com>wrote:

> Hi Hiroshi,
>
> On Tue, 2013-06-25 at 19:05 -0700, Hiroshi Yamauchi wrote:
> > Here's an updated
> > webrev:
> http://cr.openjdk.java.net/~hiroshi/webrevs/edenchunks/webrev.01/
> >
> > Let me know if there are more comments.
>
> Minor nitpick:
>
> concurrentMarkSweepGeneration.cpp:
>
> 4516   if (_eden_chunk_array && !CMSEdenChunksRecordAlways) {
>
> The != NULL has been forgotten here.
>
> Thanks for considering to use the mutex in
> CMSCollector::sample_eden_chunk(). It looks a lot cleaner now.
>
> Looks good.
>
> Thanks,
>   Thomas
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130627/ea0e4f68/attachment.htm>


More information about the hotspot-gc-dev mailing list