RFR (S): 8013791: G1: G1CollectorPolicy::initialize_flags() may set min_alignment > max_alignment
jon.masamitsu at oracle.com
Thu May 2 19:42:47 UTC 2013
Change looks correct. I'd suggest enhancing the message from the
assertion to include printing values being checked plus the region size
and card table size.
On 5/2/13 11:16 AM, Bengt Rutisson wrote:
> Hi everyone,
> Could I have a couple of reviews for this small patch?
> For G1 it is important that the heap size is aligned by the region
> size. The ergonomics will pick CollectorPolicy::max_alignment() for
> aligning the heap, but this alignment is based on the card table
> rather than the region size.
> This fix makes sure that we pick the larger alignment for the
> max_alignment value and it adds the same assert for the min and max
> alignments that is available in GenCollectorPolicy::initialize_flags().
More information about the hotspot-gc-dev