RFR(S/M) [Backports of] 8005032 and 8009536
bengt.rutisson at oracle.com
Sun May 5 20:39:36 UTC 2013
Missed this review request. Sorry for the late review.
Thanks for providing the background and the good references to previous
On 4/29/13 10:07 PM, John Cuthbertson wrote:
> Hi Everyone,
> Can I have a couple of volunteers review the back ports of the changes
> for these two CRs:
> 8005032: G1: Cleanup serial reference processing closures in
> concurrent marking
> 8009536: G1: Apache Lucene hang during reference processing
> The exported changesets did not apply cleanly because of some event
> based tracing changes, namely CMTask::worker_id() being changed to
> CMTask::task_id() and
> ReferenceProcessor::process_discovered_references() returning a value.
> Back porting the changes for 8005032 reduce the number of conflicts
> when importing the changes for 8009536.
> Since the cleanup changes expose the problem fixed by 8009536, I'd
> like to push both changesets together.
> _8005032: G1: Cleanup serial reference processing closures in
> concurrent marking_
> The webrev for the back port of 8005032 can be found at:
> The original hs25 changes can be found at:
> Testing: GC test suite (also with ParallelGCThreads=0) and event based
> tracing regression tests.
> _8009536: G1: Apache Lucene hang during reference processing_
> The webrev for just the hsx24 back port changes (applied on top of
> 8005032) can be found at:
> The combined webrev can be found at:
> The original changes for hsx25 can be found at:
> Testing: GC test suite, the Apache Lucene uima tests with
> MarkStackSize=32K entries.
One very minor nit. For hs25 you fixed one indentation of a "}" that you
did not fix in hs24. :)
hs24, concurrentMark.cpp - new file
hs25, concurrentMark.cpp - new file
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev