RFR (L): JDK-6843347 Boundary values in some public GC options cause crashes
bengt.rutisson at oracle.com
Tue May 14 06:47:50 UTC 2013
In arguments.cpp you check for MarkSweepAlwaysCompactCount == 0 and in
that case silently set MarkSweepAlwaysCompactCount = 1. I think I would
prefer not to reset it and let there be an error message when we hit
"MarkSweepAlwaysCompactCount");" further down. Otherwise people won't
know that they have made a mistake on the command line if they run with
One minor nit:
In psMarkSweep.cpp you updated one line to be:
unsigned int count = (maximum_heap_compaction)? 1 :
I don't think the parenthesis increase readability here, but it would
help with a space before the ?. Also, I am more used to seeing uint
instead of unsigned int, but HotSpot has a lot of occurrences of both
variants, so I leave it up to you to choose. So, to summarize I would
uint count = maximum_heap_compaction ? 1 : MarkSweepAlwaysCompactCount;
Otherwise looks good!
On 5/13/13 9:42 PM, Thomas Schatzl wrote:
> Hi all,
> after an internal review, please have a look at the current version.
> The difference to the previous is
> - change the type of MarkSweepAlwaysCompactCount from intx to uintx,
> with related changes.
> Difference to the first version
> - minimum value for HeapSizePerGCThread is os::vm_page_size() (suggested
> by Jon M.)
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev