Request for review: 8007763: Refactoring: split up compute_generation_free_space() into two functions for class PSAdaptiveSizePolicy
thomas.schatzl at oracle.com
Tue May 14 12:06:10 UTC 2013
On Mon, 2013-05-06 at 14:46 -0700, Tao Mao wrote:
> 8007763: Refactoring: split up compute_generation_free_space() into
> two functions for class PSAdaptiveSizePolicy
The change looks okay after thorough visual inspection and given your
testing there seem to be no regressions.
One note: A large part of the code surrounding the change in
psMarkSweep/psParallelCompact.cpp looks very much the same. Is there a
way to factor out something here? (Probably not as there is no common
Consider it okay from me anyway, that has been the case before too.
> Split up compute_generation_free_space() into two functions:
> compute_eden_space_size() + compute_old_gen_free_space(), each of
> which (if needed, e.g.
> src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp) can be
> reused without executing an overhead of the other.
> The changeset is also related to JDK-8007763 (Rename a bunch of
> methods in size policy across collectors).
I will look at 8007762 too.
Sorry for the delay,
More information about the hotspot-gc-dev