RFR (XS): 8027756: assert(!hr->isHumongous()) failed: code root in humongous region? (P2-JDK8!)
thomas.schatzl at oracle.com
Wed Nov 6 16:49:50 UTC 2013
On Tue, 2013-11-05 at 10:49 -0800, Tao Mao wrote:
> Hi Thomas,
> Can you make the assertion message from a question to a statement? It'll
> help future readers understand it.
> say, in g1CollectedHeap.cpp
> - assert(!hr->continuesHumongous(), "code root in continuation of
> humongous region?");
> + assert(!hr->continuesHumongous(), "code root should not attached to a
> humonguous continuation");
> There may be a couple of other similar ones.
Done for all related assertions. There are more, but I did not think
changing them fit into this changeset.
See new webrev at http://cr.openjdk.java.net/~tschatzl/8027756/webrev.1/
Also changed the test to try both server and client compilers (e.g.
-client and -server).
Thanks for the review,
More information about the hotspot-gc-dev