RFR: 8027960: Assertion assert(end >= start) failed during nightly testing on solaris

Jon Masamitsu jon.masamitsu at oracle.com
Fri Nov 8 18:52:15 UTC 2013


Change looks good.

There are _gen_alignments and _space_alignments in CollectorPolicy.
Where those are initialized there is no calculation of a new_alignment
based on page size.  For example,

void MarkSweepPolicy::initialize_alignments() {
   _space_alignment = _gen_alignment = (uintx)Generation::GenGrain;
   _heap_alignment = compute_heap_alignment();

Should those places be calculating and using a new_alignment?


On 11/8/2013 9:19 AM, Stefan Johansson wrote:
> Hi,
> Please review this small fix for:
> https://bugs.openjdk.java.net/browse/JDK-8027960
> Webrev:
> http://cr.openjdk.java.net/~sjohanss/8027960/webrev.00/
> Summary:
> The generation sizer needed to have its space-alignment updated when 
> large pages are enabled. Right now only the gen-alignment was updated 
> and then the spaces can grow to large to fit in the generation.
> Testing:
> JPRT standard testing
> Thanks,
> StefanJ

More information about the hotspot-gc-dev mailing list