RFR(XS): JDK-8027911 Assertion in the collector policy when running gc/arguments/TestMaxNewSize.java

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Sat Nov 9 22:46:06 UTC 2013


Can I have a couple of reviews for this tiny bugfix?

Bug JDK-8027911: https://bugs.openjdk.java.net/browse/JDK-8027911

The variable _initial_gen0_size should contain the same value as the flag 
NewSize. In the collector policy classes the flag and the variable may be 
updated to match other flags and ergonomics. After these changes the following 
code is supposed to update NewSize with the new value of _initial_gen0_size, but 
copy-n-paste made the code use the _max_gen0_size value instead.

I didn't make a webrev for this oneline change, I hope that is OK.

diff --git a/src/share/vm/memory/collectorPolicy.cpp 
--- a/src/share/vm/memory/collectorPolicy.cpp
+++ b/src/share/vm/memory/collectorPolicy.cpp
@@ -621,7 +621,7 @@

    // Write back to flags if necessary
    if (NewSize != _initial_gen0_size) {
-    FLAG_SET_ERGO(uintx, NewSize, _max_gen0_size);
+    FLAG_SET_ERGO(uintx, NewSize, _initial_gen0_size);

    if (MaxNewSize != _max_gen0_size) {


More information about the hotspot-gc-dev mailing list